Bug 35713

Summary: undo after smartdelete should select the deleted space
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, ap, darin, enrica, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+

Ojan Vafai
Reported 2010-03-03 18:36:43 PST
undo after smartdelete should select the deleted space
Attachments
Patch (9.87 KB, patch)
2010-03-03 18:40 PST, Ojan Vafai 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2010-03-03 18:40:13 PST
Created attachment 49976 [details] Patch
Adam Barth
Comment 2 2010-03-09 11:06:01 PST
Comment on attachment 49976 [details] Patch Ojan is slowly teaching me the editing code. I'd prefer to have someone more expert review these patches, but no one seems to be forthcoming. + void setStartingSelectionOnSmartDelete(Position&, Position&); Why pass these by reference instead of by constant reference?
Ojan Vafai
Comment 3 2010-03-09 15:41:46 PST
Committed r55752: <http://trac.webkit.org/changeset/55752>
Note You need to log in before you can comment on or make changes to this bug.