Bug 35713

Summary:

undo after smartdelete should select the deleted space

Product:

WebKit

Reporter:

Ojan Vafai <ojan>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adele, ap, darin, enrica, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	abarth: review+

Description Ojan Vafai 2010-03-03 18:36:43 PST

undo after smartdelete should select the deleted space

Comment 1 Ojan Vafai 2010-03-03 18:40:13 PST

Created attachment 49976 [details]
Patch

Comment 2 Adam Barth 2010-03-09 11:06:01 PST

Comment on attachment 49976 [details]
Patch

Ojan is slowly teaching me the editing code.  I'd prefer to have someone more expert review these patches, but no one seems to be forthcoming.

+ void setStartingSelectionOnSmartDelete(Position&, Position&);

Why pass these by reference instead of by constant reference?

Comment 3 Ojan Vafai 2010-03-09 15:41:46 PST

Committed r55752: <http://trac.webkit.org/changeset/55752>