Bug 35697

Summary: [V8] Clean up CodeGeneratorV8.pm
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch dglazkov: review+

Nate Chapin
Reported 2010-03-03 13:02:01 PST
To start with: 1. Remove some of the unused subroutines 2. Make GetInternalFields less hard-coded (though it will still need some special cases). 3. Make the generated code (mostly) match the WebKit style guide.
Attachments
patch (56.88 KB, patch)
2010-03-03 13:07 PST, Nate Chapin 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nate Chapin
Comment 1 2010-03-03 13:07:14 PST
Created attachment 49936 [details] patch
Dimitri Glazkov (Google)
Comment 2 2010-03-04 16:09:58 PST
Comment on attachment 49936 [details] patch why do you keep removing code? what has it done to you?
Nate Chapin
Comment 3 2010-03-05 10:07:19 PST
http://trac.webkit.org/changeset/55586
Note You need to log in before you can comment on or make changes to this bug.