| Summary: | [Chromium] Should remove paddings of Win/Linux chromium's buttons | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Shinichiro Hamaji <hamaji> | ||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | arv, hyatt, ojan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
|
Description
Shinichiro Hamaji
2010-03-02 22:18:09 PST
Created attachment 49878 [details]
Patch v1
> Created an attachment (id=49878) [details]
> Patch v1
Or, should we remove buttonInternalPadding* even from RenderTheme ? David, could you give me your suggestion if you have any opinion about this?
Comment on attachment 49878 [details]
Patch v1
cq- because this patch will break bunch of chromium's layout tests so I need to communicate with WebKit sheriff before I land this patch.
Comment on attachment 49878 [details]
Patch v1
OK.
To give context for this. We've found a number of sites whose layout breaks due to this extra internal padding. We originally added this to match Firefox since padding:0 buttons look pretty crappy without having any internal padding. Chromium would like to run an experiment removing the padding and see if there's any fallout. We're hoping that not many sites use padding:0. If it turns out they do, then we'll probably revert this change. If they don't, we should consider making Safari Win also not having internal button padding. Some sites that break with the internal padding: http://topkayaker.net/TopKayakerShop/ http://www.qotsa.com/ http://catalinaexpress.com/ http://www.dekalb.k12.ga.us/ http://balkanweb.com/poll/pollsys/ http://www.indianmasala.com/ Comment on attachment 49878 [details] Patch v1 Clearing flags on attachment: 49878 Committed r55714: <http://trac.webkit.org/changeset/55714> All reviewed patches have been landed. Closing bug. |