Bug 35629 – [Chromium] Should remove paddings of Win/Linux chromium's buttons

• Component: CSS
• Status: RESOLVED FIXED

[Shinichiro Hamaji]

Per discussion on Bug 35231 and http://code.google.com/p/chromium/issues/detail?id=1437 , let's remove the extra paddings which causes web compatibility issues.

[Shinichiro Hamaji]

Created attachment 49878 [details]
Patch v1

[Shinichiro Hamaji]

> Created an attachment (id=49878) [details]
> Patch v1

Or, should we remove buttonInternalPadding* even from RenderTheme ? David, could you give me your suggestion if you have any opinion about this?

[Shinichiro Hamaji]

Comment on attachment 49878 [details]
Patch v1

cq- because this patch will break bunch of chromium's layout tests so I need to communicate with WebKit sheriff before I land this patch.

[Eric Seidel (no email)]

Comment on attachment 49878 [details]
Patch v1

OK.

[Ojan Vafai]

To give context for this. We've found a number of sites whose layout breaks due to this extra internal padding. We originally added this to match Firefox since padding:0 buttons look pretty crappy without having any internal padding.

Chromium would like to run an experiment removing the padding and see if there's any fallout. We're hoping that not many sites use padding:0. If it turns out they do, then we'll probably revert this change. If they don't, we should consider making Safari Win also not having internal button padding.

Some sites that break with the internal padding:
http://topkayaker.net/TopKayakerShop/
http://www.qotsa.com/
http://catalinaexpress.com/
http://www.dekalb.k12.ga.us/
http://balkanweb.com/poll/pollsys/
http://www.indianmasala.com/

[Shinichiro Hamaji]

Comment on attachment 49878 [details]
Patch v1

Clearing flags on attachment: 49878

Committed r55714: <http://trac.webkit.org/changeset/55714>

[Shinichiro Hamaji]

All reviewed patches have been landed.  Closing bug.

[Erik Arvidsson]

*** Bug 31703 has been marked as a duplicate of this bug. ***