Bug 35627
| Summary: | Rework r55443 to avoid #ifdefs in Page.cpp | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Fisher (:fishd, Google) <fishd> |
| Component: | Plug-ins | Assignee: | Darin Fisher (:fishd, Google) <fishd> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | mrowe |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Darin Fisher (:fishd, Google)
Rework http://trac.webkit.org/changeset/55443 to avoid #ifdefs in Page.cpp
One idea is to move the body of Page::privateBrowsingStateChanged to a
static function on PluginView. That function would be passed the Page,
and it would then iterate over the list of PluginViews and notify each.
This way PluginViewNone.cpp can just have an empty body for that static
method.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Mark Rowe (bdash)
*** This bug has been marked as a duplicate of bug 35623 ***