Summary: | Page should not care about Chromium plug-in implementation details | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Rowe (bdash) <mrowe> | ||||
Component: | Plug-ins | Assignee: | Darin Fisher (:fishd, Google) <fishd> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fishd | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Mark Rowe (bdash)
2010-03-02 17:23:55 PST
*** Bug 35627 has been marked as a duplicate of this bug. *** From bug 35627: > One idea is to move the body of Page::privateBrowsingStateChanged to a > static function on PluginView. That function would be passed the Page, > and it would then iterate over the list of PluginViews and notify each. > > This way PluginViewNone.cpp can just have an empty body for that static > method. Sound good? Created attachment 49933 [details]
v1 patch
Just building PluginViewNone.cpp turns out to be sufficient. Page::privateBrowsingStateChanged() is optimized away (tested using Visual Studio 8).
Landed as http://trac.webkit.org/changeset/55486 |