Bug 35614

Summary: delete pywebsocket dir again (revert r55339)
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: cjerdonek, dpranke, dumi, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch levin: review+

Dirk Pranke
Reported 2010-03-02 15:46:40 PST
delete pywebsocket dir again (revert r55339)
Attachments
Patch (3.06 KB, patch)
2010-03-02 15:49 PST, Dirk Pranke 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-03-02 15:49:13 PST
Created attachment 49858 [details] Patch
Dirk Pranke
Comment 2 2010-03-02 16:17:06 PST
Committed r55439: <http://trac.webkit.org/changeset/55439>
Chris Jerdonek
Comment 3 2010-03-03 10:35:29 PST
+ Revert r55339 - the Chromium codebase downstream had a temporary + need for WebKitTools/pywebsocket to still exist after Chris Jerdonek + had moved it (scripts still referenced the old location). Those + scripts have been updated to the new location, so it should be safe + to delete this now. If possible, it's probably better to arrange things on the Chromium side to only depends on things located in WebKitTools/Scripts (rather than on the location of things in the internal API). This may require adding a new script to the Scripts folder. That way if we ever move something in webkitpy again, people in WebKit will be able to update the dependent scripts in WebKitTools/Scripts accordingly.
Note You need to log in before you can comment on or make changes to this bug.