Bug 35601

Summary: new-run-webkit-tests doesn't work on chromium-win (close_fds not supported)
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch dglazkov: review+

Dirk Pranke
Reported 2010-03-02 13:59:18 PST
Bug 35553 introduced a workaround to a python bug in subprocess.open(). Unfortunately, the workaround causes new-run-webkit-tests to fail outright on windows because the parameter (close_fds) isn't supported.
Attachments
Patch (1.93 KB, patch)
2010-03-02 14:02 PST, Dirk Pranke 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-03-02 14:02:46 PST
Created attachment 49844 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2010-03-02 14:15:17 PST
Comment on attachment 49844 [details] Patch ok.
Dirk Pranke
Comment 3 2010-03-02 16:14:46 PST
Fix landed as http://trac.webkit.org/changeset/55434 .
Note You need to log in before you can comment on or make changes to this bug.