Bug 35600

Summary:

shouldBe() fails when comparing an array to null

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed fix	aroben: review+
a working fix	aroben: review+

Description Alexey Proskuryakov 2010-03-02 13:48:15 PST

Patch forthcoming.

Comment 1 Alexey Proskuryakov 2010-03-02 13:50:06 PST

Created attachment 49842 [details]
proposed fix

Comment 2 Adam Roben (:aroben) 2010-03-02 13:52:32 PST

Comment on attachment 49842 [details]
proposed fix

r=me

Comment 3 Alexey Proskuryakov 2010-03-02 14:10:46 PST

Created attachment 49847 [details]
a working fix

Comment 4 Adam Roben (:aroben) 2010-03-02 14:12:46 PST

Comment on attachment 49847 [details]
a working fix

Is there any value in communicating more information about what happened?

r=me

Comment 5 Alexey Proskuryakov 2010-03-02 14:26:18 PST

Committed <http://trac.webkit.org/changeset/55430>.

> Is there any value in communicating more information about what happened?

Not in this specific case - shouldBe(myArray, null) just needs to silently return false. It may be more interesting in other cases, but it may be not.