Bug 35600

Summary: shouldBe() fails when comparing an array to null
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed fix
aroben: review+
a working fix aroben: review+

Alexey Proskuryakov
Reported 2010-03-02 13:48:15 PST
Patch forthcoming.
Attachments
proposed fix (1.41 KB, patch)
2010-03-02 13:50 PST, Alexey Proskuryakov 		aroben: review+
DetailsFormatted DiffDiff
a working fix (1.44 KB, patch)
2010-03-02 14:10 PST, Alexey Proskuryakov 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-03-02 13:50:06 PST
Created attachment 49842 [details] proposed fix
Adam Roben (:aroben)
Comment 2 2010-03-02 13:52:32 PST
Comment on attachment 49842 [details] proposed fix r=me
Alexey Proskuryakov
Comment 3 2010-03-02 14:10:46 PST
Created attachment 49847 [details] a working fix
Adam Roben (:aroben)
Comment 4 2010-03-02 14:12:46 PST
Comment on attachment 49847 [details] a working fix Is there any value in communicating more information about what happened? r=me
Alexey Proskuryakov
Comment 5 2010-03-02 14:26:18 PST
Committed <http://trac.webkit.org/changeset/55430>. > Is there any value in communicating more information about what happened? Not in this specific case - shouldBe(myArray, null) just needs to silently return false. It may be more interesting in other cases, but it may be not.
Note You need to log in before you can comment on or make changes to this bug.