Bug 35588

Summary:

[V8] NPN_GetProperty shouldn't crash if the property doesn't exist

Product:

WebKit

Reporter:

Nate Chapin <japhet>

Component:

WebCore Misc.

Assignee:

Nate Chapin <japhet>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, dglazkov

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	dglazkov: review+

Nate Chapin

Reported 2010-03-02 10:40:02 PST

Currently, if the property doesn't exist, v8::Object::Get() returns an empty handle and we fail an ASSERT when we try to convert that handle to an NPVariant, so we should exit early before trying to convert.

Attachments
patch (1.30 KB, patch) 2010-03-02 10:43 PST, Nate Chapin	dglazkov: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Nate Chapin

Comment 1 2010-03-02 10:43:01 PST

Created attachment 49818 [details] patch

Dimitri Glazkov (Google)

Comment 2 2010-03-02 11:07:07 PST

Comment on attachment 49818 [details] patch ok.

Alexey Proskuryakov

Comment 3 2010-03-02 17:11:50 PST

This was landed in <http://trac.webkit.org/changeset/55417>.

Note You need to log in before you can comment on or make changes to this bug.