Bug 35587

Summary:

Test plugin still has issues with releasing objects, and variants

Product:

WebKit

Reporter:

Gustavo Noronha (kov) <gustavo>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
proposed patch	gustavo: commit-queue-

Gustavo Noronha (kov)

Reported 2010-03-02 10:18:47 PST

ap found out my patch to fix releasing variants was a bit wrong in a couple places, and that the plugin failed to release a bunch of variables it should.

Attachments
proposed patch (4.74 KB, patch) 2010-03-02 10:24 PST, Gustavo Noronha (kov)	gustavo: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gustavo Noronha (kov)

Comment 1 2010-03-02 10:24:05 PST

Created attachment 49816 [details] proposed patch This covers all issues ap found, and discussed with me on IRC.

Alexey Proskuryakov

Comment 2 2010-03-02 10:25:29 PST

Comment on attachment 49816 [details] proposed patch r=me

Gustavo Noronha (kov)

Comment 3 2010-03-02 10:34:57 PST

Comment on attachment 49816 [details] proposed patch Landed as r55415.

Note You need to log in before you can comment on or make changes to this bug.