Bug 35587 - Test plugin still has issues with releasing objects, and variants
Summary: Test plugin still has issues with releasing objects, and variants
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-02 10:18 PST by Gustavo Noronha (kov)
Modified: 2010-03-02 10:35 PST (History)
0 users

See Also:


Attachments
proposed patch (4.74 KB, patch)
2010-03-02 10:24 PST, Gustavo Noronha (kov)
gns: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2010-03-02 10:18:47 PST
ap found out my patch to fix releasing variants was a bit wrong in a couple places, and that the plugin failed to release a bunch of variables it should.
Comment 1 Gustavo Noronha (kov) 2010-03-02 10:24:05 PST
Created attachment 49816 [details]
proposed patch

This covers all issues ap found, and discussed with me on IRC.
Comment 2 Alexey Proskuryakov 2010-03-02 10:25:29 PST
Comment on attachment 49816 [details]
proposed patch

r=me
Comment 3 Gustavo Noronha (kov) 2010-03-02 10:34:57 PST
Comment on attachment 49816 [details]
proposed patch

Landed as r55415.