Bug 35586

Summary:

Make IntPoint usable as a hash key

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	none
move to IntPointHash.h to avoid including hash headers all over the place	oliver: review+

Description Antti Koivisto 2010-03-02 10:06:51 PST

What the title says.

Comment 1 Antti Koivisto 2010-03-02 10:10:40 PST

Created attachment 49812 [details]
patch

Comment 2 WebKit Review Bot 2010-03-02 10:19:31 PST

Attachment 49812 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/IntPoint.h:220:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Darin Adler 2010-03-02 10:25:57 PST

Comment on attachment 49812 [details]
patch

In the case of WebCore::String we chose to put the hashing into a separate header rather than adding HashFunctions.h and HashTraits.h into every files that includes PlatformString.h. Perhaps we should do the same thing here?

Comment 4 Antti Koivisto 2010-03-02 13:39:00 PST

(In reply to comment #3)
> (From update of attachment 49812 [details])
> In the case of WebCore::String we chose to put the hashing into a separate
> header rather than adding HashFunctions.h and HashTraits.h into every files
> that includes PlatformString.h. Perhaps we should do the same thing here?

Yeah, good idea. This is included all over.

Comment 5 Antti Koivisto 2010-03-03 03:40:28 PST

Created attachment 49896 [details]
move to IntPointHash.h to avoid including hash headers all over the place

Comment 6 Oliver Hunt 2010-03-03 03:44:27 PST

Comment on attachment 49896 [details]
move to IntPointHash.h to avoid including hash headers all over the place

r=me, assuming you remove the superfluous project file changes

Comment 7 Antti Koivisto 2010-03-03 04:53:02 PST

Sending        WebCore/ChangeLog
Sending        WebCore/WebCore.pro
Sending        WebCore/WebCore.xcodeproj/project.pbxproj
Adding         WebCore/platform/graphics/IntPointHash.h
Transmitting file data ....
Committed revision 55455.