Bug 35552

Summary: [V8] DOMCoreException should be visible as DOMException
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore Misc.Assignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Patch japhet: review+, jianli: commit-queue-

Description Jian Li 2010-03-01 16:01:06 PST
We need to make DOMCoreException be visible as DOMException, similar to what JSC code generator does. This will fix several wrong layout test results, like LayoutTests/fast/dom/DOMException/prototype-object.html has the following wrong result:

FAIL Object.prototype.toString.call(e) should be [object DOMException]. Was [object DOMCoreException].
...
FAIL e.constructor.toString() should be [object DOMExceptionConstructor]. Was function DOMCoreException() { [native code] }.

This will also apply to FormData interface I am going to add at 26979.
Comment 1 Jian Li 2010-03-01 16:35:17 PST
Created attachment 49763 [details]
Proposed Patch
Comment 2 Nate Chapin 2010-03-02 10:48:23 PST
Comment on attachment 49763 [details]
Proposed Patch

Yay for passing layout tests!
Comment 3 Jian Li 2010-03-02 11:05:11 PST
Committed as http://trac.webkit.org/changeset/55416.