Bug 35535

Summary:

Web Inspector: render breakpoints as border images instead of canvas.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, joepeck, rik, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[IMAGE] Screenshot while running with patch.	none
[PATCH] Proposed change.	timothy: review+

Description Pavel Feldman 2010-03-01 12:31:47 PST

Now that the line number gutter is of variable width, we should support variable width breakpoint images.

Comment 1 Pavel Feldman 2010-03-01 12:33:28 PST

Created attachment 49735 [details]
[IMAGE] Screenshot while running with patch.

Comment 2 Pavel Feldman 2010-03-01 12:35:37 PST

Created attachment 49736 [details]
[PATCH] Proposed change.

Comment 3 Timothy Hatcher 2010-03-01 13:22:31 PST

Comment on attachment 49736 [details]
[PATCH] Proposed change.

You can use -webkit-canvas() as a border-image. But I am fine checking in static images too.

Comment 4 Pavel Feldman 2010-03-02 06:37:50 PST

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	A	WebCore/inspector/front-end/Images/breakpointBorder.png
	A	WebCore/inspector/front-end/Images/breakpointConditionalBorder.png
	A	WebCore/inspector/front-end/Images/breakpointConditionalCounterBorder.png
	A	WebCore/inspector/front-end/Images/breakpointCounterBorder.png
	A	WebCore/inspector/front-end/Images/programCounterBorder.png
	M	WebCore/inspector/front-end/SourceFrame.js
	M	WebCore/inspector/front-end/TextViewer.js
	M	WebCore/inspector/front-end/textViewer.css
Committed r55407