|Summary:||REGRESSION: [view goToBackForwardItem:[[view backForwardList] currentItem]] is broken|
|Product:||WebKit||Reporter:||Brady Eidson <beidson>|
|Component:||Page Loading||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||aroben, eric, sfalken|
|Version:||528+ (Nightly build)|
Description Brady Eidson 2010-03-01 11:20:07 PST
The following previously working code is broken: WebView* view = */ some view /*; [view goToBackForwardItem:[[view backForwardList] currentItem]]; Telling a Page/FrameLoader to go to the same HistoryItem that is its current HistoryItem is supposed to effectively reload the page. creating a new load and new document. With the changes to FrameLoader for state objects and certain hash navigations be "same document" navigations, this API started acting as a "same document load" One concrete example of where this breaks Safari is in the anti-phishing warning, where you can no longer "ignore" an anti-phishing alert. "http://aboutbillgates.com" is a current example of a site google has flagged as malware and can be used to test this breakage. The WebCore fix is easy, a layout test requires an API specific addition, and a patch is on its way.
Comment 3 Sam Weinig 2010-03-01 12:54:52 PST
Comment on attachment 49732 [details] Fix + layouttest r=me. Thanks for making a test for this.
Comment 5 Eric Seidel (no email) 2010-03-05 14:08:40 PST
This new test is broken on windows: http://build.webkit.org/results/Windows%20Debug%20(Tests)/r55554%20(10403)/results.html I'm not sure how long it's been broken, but longer than the buildbot can remember. :(
Comment 6 Brady Eidson 2010-03-05 15:02:28 PST
We need to add it to the skipped list I guess, because I won't be able to look at it on windows in the short term.
Comment 7 Eric Seidel (no email) 2010-03-05 15:05:12 PST
rs=me on doing so.