Bug 35516

Summary:

[Qt] GraphicsLayer: Video element with 3d transform crashes when AC is enabled.

Product:

WebKit

Reporter:

Kim Grönholm <kim.1.gronholm>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, noam, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Video element with 3d transformation	none
Prevents the crash.	none
Patch for preventing the crash in bug #35516	none
Updated patch for preventing the crash in bug #35516	none

Kim Grönholm

Reported 2010-03-01 00:30:34 PST

Created attachment 49711 [details] Video element with 3d transformation The crash happens because GraphicsLayerQt::setContentsToMedia(PlatformLayer* media) gets called with media==NULL. Attached a test page that demonstrates the issue. The crash doesn't happen if ACCELERATED_COMPOSITING is disabled.

Attachments
Video element with 3d transformation (280 bytes, text/html) 2010-03-01 00:30 PST, Kim Grönholm	no flags	Details
Prevents the crash. (1.51 KB, patch) 2010-03-01 00:38 PST, Kim Grönholm	no flags	Details Formatted Diff Diff
Patch for preventing the crash in bug #35516 (1.54 KB, patch) 2010-03-01 02:15 PST, Kim Grönholm	no flags	Details Formatted Diff Diff
Updated patch for preventing the crash in bug #35516 (1.53 KB, patch) 2010-03-01 04:58 PST, Kim Grönholm	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Kim Grönholm

Comment 1 2010-03-01 00:38:26 PST

Created attachment 49712 [details] Prevents the crash. This patch only prevents the crash without tackling the issue why the 'media'-pointer is NULL.

Noam Rosenthal

Comment 2 2010-03-01 01:37:06 PST

The parameter is null when the compositor wants to cancel the compositing of this video element, and move it back to the regular renderer. we should, in that case, change the content type to HTML and not leave it as video.

Kim Grönholm

Comment 3 2010-03-01 02:15:43 PST

Created attachment 49715 [details] Patch for preventing the crash in bug #35516 Made the changes Noam requested and submitted a new patch.

Noam Rosenthal

Comment 4 2010-03-01 04:39:29 PST

You should r? cq? it again, if it's complete

WebKit Review Bot

Comment 5 2010-03-01 04:54:36 PST

Attachment 49715 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:857: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Kim Grönholm

Comment 6 2010-03-01 04:58:46 PST

Created attachment 49720 [details] Updated patch for preventing the crash in bug #35516 Fixed a style issue in the patch.

WebKit Commit Bot

Comment 7 2010-03-02 12:15:34 PST

Comment on attachment 49720 [details] Updated patch for preventing the crash in bug #35516 Clearing flags on attachment: 49720 Committed r55421: <http://trac.webkit.org/changeset/55421>

WebKit Commit Bot

Comment 8 2010-03-02 12:15:38 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.