Bug 35514

Summary:

AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	darin: review+

Description chris fleizach 2010-02-28 23:22:12 PST

when a grid changes its DOM, and VoiceOver asks for an attribute like AXRows, the children are not updated

Comment 1 chris fleizach 2010-03-01 00:03:01 PST

Created attachment 49709 [details]
patch

Comment 2 Darin Adler 2010-03-01 14:11:32 PST

Comment on attachment 49709 [details]
patch

Seems to me that this idiom:

    if (needsToUpdateChildren())
        clearChildren();

    if (!hasChildren())
        addChildren();

Should be in a helper function. It's not good to repeat it all those different places.

Can we make the needsToUpdateChildren protected instead of public?

Comment 3 chris fleizach 2010-03-01 14:12:36 PST

(In reply to comment #2)
> (From update of attachment 49709 [details])
> Seems to me that this idiom:
> 
>     if (needsToUpdateChildren())
>         clearChildren();
> 
>     if (!hasChildren())
>         addChildren();
> 
> Should be in a helper function. It's not good to repeat it all those different
> places.
> 

Will do

> Can we make the needsToUpdateChildren protected instead of public?

Yes, this patch makes it protected instead of private

Comment 4 chris fleizach 2010-03-01 17:19:45 PST

http://trac.webkit.org/changeset/55390