Bug 35514

Summary: AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch darin: review+

chris fleizach
Reported 2010-02-28 23:22:12 PST
when a grid changes its DOM, and VoiceOver asks for an attribute like AXRows, the children are not updated
Attachments
patch (11.91 KB, patch)
2010-03-01 00:03 PST, chris fleizach 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
chris fleizach
Comment 1 2010-03-01 00:03:01 PST
Created attachment 49709 [details] patch
Darin Adler
Comment 2 2010-03-01 14:11:32 PST
Comment on attachment 49709 [details] patch Seems to me that this idiom: if (needsToUpdateChildren()) clearChildren(); if (!hasChildren()) addChildren(); Should be in a helper function. It's not good to repeat it all those different places. Can we make the needsToUpdateChildren protected instead of public?
chris fleizach
Comment 3 2010-03-01 14:12:36 PST
(In reply to comment #2) > (From update of attachment 49709 [details]) > Seems to me that this idiom: > > if (needsToUpdateChildren()) > clearChildren(); > > if (!hasChildren()) > addChildren(); > > Should be in a helper function. It's not good to repeat it all those different > places. > Will do > Can we make the needsToUpdateChildren protected instead of public? Yes, this patch makes it protected instead of private
chris fleizach
Comment 4 2010-03-01 17:19:45 PST
http://trac.webkit.org/changeset/55390
Note You need to log in before you can comment on or make changes to this bug.