Summary: | AX: changes to WAI-ARIA grid aren't perceived correctly by VoiceOver | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | chris fleizach <cfleizach> | ||||
Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
chris fleizach
2010-02-28 23:22:12 PST
Created attachment 49709 [details]
patch
Comment on attachment 49709 [details]
patch
Seems to me that this idiom:
if (needsToUpdateChildren())
clearChildren();
if (!hasChildren())
addChildren();
Should be in a helper function. It's not good to repeat it all those different places.
Can we make the needsToUpdateChildren protected instead of public?
(In reply to comment #2) > (From update of attachment 49709 [details]) > Seems to me that this idiom: > > if (needsToUpdateChildren()) > clearChildren(); > > if (!hasChildren()) > addChildren(); > > Should be in a helper function. It's not good to repeat it all those different > places. > Will do > Can we make the needsToUpdateChildren protected instead of public? Yes, this patch makes it protected instead of private |