|Summary:||check-webkit-style: Disable most PEP8 checks for webkitpy/thirdparty|
|Product:||WebKit||Reporter:||Chris Jerdonek <cjerdonek>|
|Component:||Tools / Tests||Assignee:||Chris Jerdonek <cjerdonek>|
|Severity:||Normal||CC:||abarth, cjerdonek, eric, hamaji, levin|
|Version:||528+ (Nightly build)|
Description Chris Jerdonek 2010-02-28 11:44:46 PST
We may still want to check for things like tabs, carriage returns, and trailing white space. So perhaps something like the following in the path rules specifier variable: (["webkitpy/thirdparty/"], ["-", # Disable all checks but the following. "+pep8/W191", # No tabs. "+pep8/W291", # No trailing white space. "+whitespace/carriage_return"]),
Comment 2 Shinichiro Hamaji 2010-02-28 20:19:01 PST
Comment on attachment 49703 [details] Proposed patch Nice usage of the path based filter!
Comment 3 Chris Jerdonek 2010-02-28 21:01:01 PST
(In reply to comment #2) > (From update of attachment 49703 [details]) Thanks for reviewing! I suppose I could also have gotten away with just: -pep8, +pep8/W191, +pep8/W291, but this makes the checked categories explicit.