| Summary: | Resizing requests are triggered only for uniform content size changes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kalle Vahlman <zuh> | ||||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
Attachment 49693 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:433: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 49694 [details]
Re-made patch to fix (original) style issues
Comment on attachment 49694 [details]
Re-made patch to fix (original) style issues
Thanks for the patch!
Comment on attachment 49694 [details] Re-made patch to fix (original) style issues Clearing flags on attachment: 49694 Committed r55378: <http://trac.webkit.org/changeset/55378> All reviewed patches have been landed. Closing bug. |
Created attachment 49693 [details] Patch to trigger resizes when either of content dimensions change ChromeClient::contentsSizeChanged() currently only triggers resizing if both dimensions change, this is seems obviously wrong.