Bug 35464

Summary: Fix Chromium's WebKit canaries
Product: WebKit Reporter: Dumitru Daniliuc <dumi>
Component: New BugsAssignee: Dumitru Daniliuc <dumi>
Status: RESOLVED FIXED    
Severity: Critical CC: dpranke
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
abarth: review+, dumi: commit-queue-
moving the script to the right location dglazkov: review+, dumi: commit-queue-

Description Dumitru Daniliuc 2010-02-26 17:38:46 PST 
Some scripts were moved from WebKitTools/pywebsocket to WebKitTools/Scripts. That broke Chromium's WebKit canaries. In order to fix that, we'd need to update some Chromium scripts. If we do that though, we need to pull in a newer WebCore revision into Chromium, and we can't do that right now, because lots of layout tests are failing.

So for now we should add back the relevant script(s) and remove them later once the layout tests pass, a newer WebKit version is pulled into Chromium and Chromium's scripts are updated.
Comment 1 Dumitru Daniliuc 2010-02-26 17:42:14 PST 
Created attachment 49668 [details]
patch
Comment 2 Dirk Pranke 2010-02-26 17:43:06 PST 
Comment on attachment 49668 [details]
patch

LGTM
Comment 3 Dirk Pranke 2010-02-26 17:43:29 PST 
(In reply to comment #2)
> (From update of attachment 49668 [details])
> LGTM

I will remove this and update the downstream files once we get past the roll.
Comment 4 Adam Barth 2010-02-26 17:44:04 PST 
Comment on attachment 49668 [details]
patch

ok
Comment 5 Dumitru Daniliuc 2010-02-26 17:54:47 PST 
Landed as r55329.
Comment 6 Dumitru Daniliuc 2010-02-26 18:59:10 PST 
We put the script in the wrong location.
Comment 7 Dumitru Daniliuc 2010-02-26 19:10:51 PST 
Created attachment 49670 [details]
moving the script to the right location
Comment 8 Dimitri Glazkov (Google) 2010-02-26 19:23:15 PST 
Comment on attachment 49670 [details]
moving the script to the right location

ok
Comment 9 Dumitru Daniliuc 2010-02-26 19:28:04 PST 
Second patch landed as r55336.