Summary: | Add ability to hide WebFrame scrollbars and to allow scrollbars to overlap with content. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jing <jingidy+wk> | ||||||||
Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, eric | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac (Intel) | ||||||||||
OS: | OS X 10.6 | ||||||||||
Attachments: |
|
Description
Jing
2010-02-26 14:03:52 PST
Created attachment 49637 [details]
Patch
Comment on attachment 49637 [details] Patch > + frame.size.height = (allowScrollersToOverlapContent ? NSMaxY([[self horizontalScroller] frame]) > + : NSMinY([[self horizontalScroller] frame])); > + frame.size.width = (allowScrollersToOverlapContent ? NSMaxX([[self verticalScroller] frame]) > + : NSMinX([[self verticalScroller] frame])); Just put those on one line. You are not saving much space. > + [[self window] disableFlushWindow]; > + [super tile]; > + [[self contentView] setFrame:[self contentViewFrame]]; > + [[self window] enableFlushWindow]; I don't think you need disableFlushWindow here. I don't think tile will display and flush. > + if (allowScrollersToOverlapContent) > + [self setDrawsBackground:NO]; Does this need set back to the previous value if allowScrollersToOverlapContent becomes NO again? > > + if (allowScrollersToOverlapContent)
> > + [self setDrawsBackground:NO];
>
> Does this need set back to the previous value if allowScrollersToOverlapContent
> becomes NO again?
Nope , drawsBackground gets set else-where before -reflectScrolledClipView is called.
Created attachment 49650 [details]
Patch
Revised according to Tim's comments.
Created attachment 49677 [details]
Move to WebFramePrivate Patch
Moved implementation to WebFramePrivate.
Comment on attachment 49677 [details] Move to WebFramePrivate Patch Clearing flags on attachment: 49677 Committed r55349: <http://trac.webkit.org/changeset/55349> Comment on attachment 49637 [details] Patch Cleared Timothy Hatcher's review+ from obsolete attachment 49637 [details] so that this bug does not appear in http://webkit.org/pending-commit. Does this still need landing, or can it be closed? It's landed. |