| Summary: | Merge ValidityState-stepMismatch-{number,range,unsupported}.html and input-step-{number,range,unsupported}.html to other tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, hamaji, levin | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 49594 [details]
Proposed patch
Why? (In reply to comment #2) > Why? It's an advice by Darin (Apple). We don't need to separate related tests into multiple files for script-tests because we can detect what test failed by looking at the test result. However the separated tests are not wrong. This change is not important at all. (In reply to comment #2) > Why? Comment on attachment 49594 [details]
Proposed patch
Looks good, but could you check if the combined test is fast enough in debug mode? Sometimes big tests introduce flakiness...
Also, could you put the bug number where Darin commented in this bug? It would make the motivation of this change clearer.
(In reply to comment #5) > (From update of attachment 49594 [details]) > Looks good, but could you check if the combined test is fast enough in debug > mode? Sometimes big tests introduce flakiness... For run-webkit-tests --debug LayoutTests/fast/forms/ValidityState-stepMismatch.html LayoutTests/fast/forms/input-stepup-stepdown.html, | Running tests from /Users/tkent/WebKit/LayoutTests | Testing 2 test cases. | fast/forms .. | 0.68s total testing time | | all 2 test cases succeeded > Also, could you put the bug number where Darin commented in this bug? It would > make the motivation of this change clearer. https://bugs.webkit.org/show_bug.cgi?id=34483#c2 Comment on attachment 49594 [details] Proposed patch Clearing flags on attachment: 49594 Committed r55423: <http://trac.webkit.org/changeset/55423> All reviewed patches have been landed. Closing bug. |
Merge ValidityState-stepMismatch-{number,range,unsupported}.html and input-step-{number,range,unsupported}.html to other tests