| Summary: | fix check_sys_deps/start_helper ordering, and fix check_sys_deps proto on mac | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
| Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, eric, ojan | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Dirk Pranke
2010-02-24 16:14:53 PST
Created attachment 49449 [details]
Patch
Comment on attachment 49449 [details] Patch two things to consider below. > diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog > + http://ubgs.webkit.org/show_bug.cgi?id=35367 typo: "ubgs" > diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py b/WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py > + # Check that the system dependencies (themes, fonts, ...) are correct. > + if not options.nocheck_sys_deps: > + if not port_obj.check_sys_deps(test_runner.needs_http()): Why not do an "and" instead of nested if's. > + sys.exit(1) (In reply to comment #2) > (From update of attachment 49449 [details]) > two things to consider below. > > > diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog > > + http://ubgs.webkit.org/show_bug.cgi?id=35367 > > typo: "ubgs" whoops. > > > diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py b/WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py > > > + # Check that the system dependencies (themes, fonts, ...) are correct. > > + if not options.nocheck_sys_deps: > > + if not port_obj.check_sys_deps(test_runner.needs_http()): > > Why not do an "and" instead of nested if's. > > > + sys.exit(1) will do. |