Bug 35367 – fix check_sys_deps/start_helper ordering, and fix check_sys_deps proto on mac

• Component: New Bugs
• Status: RESOLVED FIXED

[Dirk Pranke]

fix check_sys_deps/start_helper ordering, and fix check_sys_deps proto on mac

[Dirk Pranke]

Created attachment 49449 [details]
Patch

[David Levin]

Comment on attachment 49449 [details]
Patch

two things to consider below.

> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> +        http://ubgs.webkit.org/show_bug.cgi?id=35367

typo: "ubgs"

> diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py b/WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py

> +    # Check that the system dependencies (themes, fonts, ...) are correct.
> +    if not options.nocheck_sys_deps:
> +        if not port_obj.check_sys_deps(test_runner.needs_http()):

Why not do an "and" instead of nested if's.

> +            sys.exit(1)

[Dirk Pranke]

(In reply to comment #2)
> (From update of attachment 49449 [details])
> two things to consider below.
> 
> > diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> > +        http://ubgs.webkit.org/show_bug.cgi?id=35367
> 
> typo: "ubgs"

whoops.

> 
> > diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py b/WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py
> 
> > +    # Check that the system dependencies (themes, fonts, ...) are correct.
> > +    if not options.nocheck_sys_deps:
> > +        if not port_obj.check_sys_deps(test_runner.needs_http()):
> 
> Why not do an "and" instead of nested if's.
> 
> > +            sys.exit(1)

will do.

[Dirk Pranke]

Fix landed in r55208. Closing bug.