Bug 35367 - fix check_sys_deps/start_helper ordering, and fix check_sys_deps proto on mac
Summary: fix check_sys_deps/start_helper ordering, and fix check_sys_deps proto on mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-24 16:14 PST by Dirk Pranke
Modified: 2010-02-24 17:03 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.95 KB, patch)
2010-02-24 16:17 PST, Dirk Pranke
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-02-24 16:14:53 PST
fix check_sys_deps/start_helper ordering, and fix check_sys_deps proto on mac
Comment 1 Dirk Pranke 2010-02-24 16:17:30 PST
Created attachment 49449 [details]
Patch
Comment 2 David Levin 2010-02-24 16:37:48 PST
Comment on attachment 49449 [details]
Patch

two things to consider below.

> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> +        http://ubgs.webkit.org/show_bug.cgi?id=35367

typo: "ubgs"

> diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py b/WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py

> +    # Check that the system dependencies (themes, fonts, ...) are correct.
> +    if not options.nocheck_sys_deps:
> +        if not port_obj.check_sys_deps(test_runner.needs_http()):

Why not do an "and" instead of nested if's.

> +            sys.exit(1)
Comment 3 Dirk Pranke 2010-02-24 16:38:57 PST
(In reply to comment #2)
> (From update of attachment 49449 [details])
> two things to consider below.
> 
> > diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> > +        http://ubgs.webkit.org/show_bug.cgi?id=35367
> 
> typo: "ubgs"

whoops.

> 
> > diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py b/WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py
> 
> > +    # Check that the system dependencies (themes, fonts, ...) are correct.
> > +    if not options.nocheck_sys_deps:
> > +        if not port_obj.check_sys_deps(test_runner.needs_http()):
> 
> Why not do an "and" instead of nested if's.
> 
> > +            sys.exit(1)

will do.
Comment 4 Dirk Pranke 2010-02-24 17:03:20 PST
Fix landed in r55208. Closing bug.