Bug 35345

Summary:

[chromium] Should be possible to compile V8 bindings without SVG support

Product:

WebKit

Reporter:

Dominic Mazzoni <dmazzoni>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, evan, jorlow

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch to wrap includes of svg headers.	none
Updated patch without whitespace changes.	none

Description Dominic Mazzoni 2010-02-24 08:24:26 PST

This patch wraps includes of SVG headers so that it's possible to compile the V8 bindings with SVG disabled, e.g. 'enable_svg=0'.

Comment 1 Dominic Mazzoni 2010-02-24 08:38:18 PST

Created attachment 49398 [details]
Patch to wrap includes of svg headers.

Comment 2 Evan Martin 2010-02-24 08:40:11 PST

WebKit style frowns on whitespace edits (in the copyrights).

Comment 3 Dominic Mazzoni 2010-02-24 08:44:28 PST

Created attachment 49400 [details]
Updated patch without whitespace changes.

Comment 4 Evan Martin 2010-02-24 08:47:53 PST

LGTM, thanks for fixing it (need a real reviewer to review it tho)

Comment 5 Jeremy Orlow 2010-02-24 09:10:35 PST

r=me

Comment 6 WebKit Commit Bot 2010-02-24 20:43:26 PST

Comment on attachment 49400 [details]
Updated patch without whitespace changes.

Clearing flags on attachment: 49400

Committed r55217: <http://trac.webkit.org/changeset/55217>

Comment 7 WebKit Commit Bot 2010-02-24 20:43:31 PST

All reviewed patches have been landed.  Closing bug.