Summary: | HTMLSelectElement::setSelectedIndexByUser() can trigger unnecessary JS when there is no change to the selected index | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Sullivan <sullivan> | ||||
Component: | Forms | Assignee: | John Sullivan <sullivan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
John Sullivan
2010-02-22 12:38:28 PST
Created attachment 49235 [details]
Patch to bail out of setSelectedIndexByUser when the new index matches the old one
Fixed in <http://trac.webkit.org/changeset/55101> Comment on attachment 49235 [details]
Patch to bail out of setSelectedIndexByUser when the new index matches the old one
Can't we write a manual test? One which would simply alert() on the change?
:( for lack of testing. A manual test would have to be dependent on a particular client, since setSelectedIndexByUser() is not called if the user brings up the pop-up menu and then dismisses it with the initially-selected item still selected. So that's more in the realm of testing the browser than testing WebCore, I think. |