Bug 35242

Summary: Settings::setGeolocationEnabled and Settings::geolocationEnabled are redundant
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bulach, commit-queue, joth, sam, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Steve Block 2010-02-22 08:55:46 PST 
Settings::setGeolocationEnabled and Settings::geolocationEnabled were added in http://trac.webkit.org/changeset/51660

They are not used in WebCore as an alternative method to enable Geolocation at runtime was added in http://trac.webkit.org/changeset/53406

These methods should be removed.
Comment 1 Sam Weinig 2010-02-22 09:23:43 PST 
Isn't the RuntimeEnabled stuff v8/chromium specific?
Comment 2 Steve Block 2010-02-22 09:55:37 PST 
> Isn't the RuntimeEnabled stuff v8/chromium specific?
Yes, RuntimeEnabledFeatures is currently used only by the V8 bindings.
Comment 3 Jonathan Dixon 2010-02-23 02:33:28 PST 
FYI all usage of Settings::setGeolocationEnabled and WebSettings::setGeolocationEnabled were removed from Chromium in http://src.chromium.org/viewvc/chrome?view=rev&revision=39707 so from our side it's now fine to go ahead remove these methods from WebKit (Note they're not wired up to actually do anything anyway, as https://bugs.webkit.org/show_bug.cgi?id=33467 shows this was abandoned in favour of RuntimeEnabledFeatures)
Comment 4 Steve Block 2010-02-23 02:55:54 PST 
Created attachment 49271 [details]
Patch
Comment 5 Jeremy Orlow 2010-02-23 04:49:02 PST 
Comment on attachment 49271 [details]
Patch

assuming this really is dead code...  r=me

Have you svn blamed these lines to see who added them and why?
Comment 6 Steve Block 2010-02-23 05:44:07 PST 
Comment on attachment 49271 [details]
Patch

> Have you svn blamed these lines to see who added them and why?
Yes, they were added by joth in http://trac.webkit.org/changeset/51660 as mentioned above
Comment 7 WebKit Commit Bot 2010-02-23 06:05:53 PST 
Comment on attachment 49271 [details]
Patch

Clearing flags on attachment: 49271

Committed r55147: <http://trac.webkit.org/changeset/55147>
Comment 8 WebKit Commit Bot 2010-02-23 06:05:58 PST 
All reviewed patches have been landed.  Closing bug.