Summary: | Build fix for PluginView | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kwang Yul Seo <skyul> | ||||||
Component: | Plug-ins | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Kwang Yul Seo
2010-02-22 00:38:42 PST
Created attachment 49191 [details]
Patch
Remove the duplicated symbol.
Comment on attachment 49191 [details] Patch Rejecting patch 49191 from commit-queue. Failed to run "['WebKitTools/Scripts/build-webkit', '--debug']" exit_code: 1 Last 500 characters of output: ility_version 1 -current_version 533.1 -o /Users/eseidel/Projects/CommitQueue/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore Undefined symbols: "__ZN7WebCore10PluginView9keepAliveEP4_NPP", referenced from: __NPN_Evaluate in NP_jsobject.o ld: symbol(s) not found collect2: ld returned 1 exit status ** BUILD FAILED ** The following build commands failed: WebCore: Ld /Users/eseidel/Projects/CommitQueue/WebKitBuild/Debug/WebCore.framework/Versions/A/WebCore normal i386 (1 failure) Full output: http://webkit-commit-queue.appspot.com/results/298800 Comment on attachment 49191 [details]
Patch
This patch breaks MAC 64 bit as PluginViewNone.cpp is used for that build.
Created attachment 49219 [details]
hope this works
This might not need a review but I'd like to the commit-bot to be involved in this.
Comment on attachment 49219 [details]
hope this works
You can always just cq+ patches and they'll go through the queue. The r+ part is only about setting the actual text of the "Reviewed by" line. Obviously the standard committer practices of what patches are allowed to be committed, etc. should be followed for any patch with the commit-queue the same as if you were committing it manually yourself. :)
Comment on attachment 49219 [details] hope this works Clearing flags on attachment: 49219 Committed r55128: <http://trac.webkit.org/changeset/55128> All reviewed patches have been landed. Closing bug. |