Bug 35228

Summary: [Gtk] Implement layoutTestController.numberOfPages
Product: WebKit Reporter: Shinichiro Hamaji <hamaji>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, gustavo, hayato, webkit.review.bot, xan.lopez, yuzo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch v1 none

Shinichiro Hamaji
Reported 2010-02-21 23:29:59 PST
This was added in Bug 34699.
Attachments
Patch v1 (5.01 KB, patch)
2010-02-21 23:30 PST, Shinichiro Hamaji 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2010-02-21 23:30:58 PST
Created attachment 49184 [details] Patch v1
WebKit Review Bot
Comment 2 2010-02-21 23:36:20 PST
Attachment 49184 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:59: webkit_web_frame_number_of_pages is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit/gtk/webkit/webkitwebframe.cpp:879: Use 0 instead of NULL. [readability/null] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Shinichiro Hamaji
Comment 3 2010-02-22 00:08:01 PST
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 > WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:59: > webkit_web_frame_number_of_pages is incorrectly named. Don't use underscores in > your identifier names. [readability/naming] [4] > WebKit/gtk/webkit/webkitwebframe.cpp:879: Use 0 instead of NULL. > [readability/null] [5] > Total errors found: 2 in 7 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Ah, I forgot to fix this false alarms. Filed Bug 35229 and submitted a patch.
Eric Seidel (no email)
Comment 4 2010-02-22 14:39:46 PST
Comment on attachment 49184 [details] Patch v1 Hot damn!
Shinichiro Hamaji
Comment 5 2010-02-23 04:43:32 PST
Comment on attachment 49184 [details] Patch v1 Clearing flags on attachment: 49184 Committed r55144: <http://trac.webkit.org/changeset/55144>
Shinichiro Hamaji
Comment 6 2010-02-23 04:43:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.