Bug 35226

Summary:

Cache JavaScript wrappers inline in DOM nodes

Product:

WebKit

Reporter:

Maciej Stachowiak <mjs>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	oliver: review+

Maciej Stachowiak

Reported 2010-02-21 20:12:48 PST

Cache JavaScript wrappers inline in DOM nodes

Attachments
Patch (15.13 KB, patch) 2010-02-21 20:29 PST, Maciej Stachowiak	no flags	Details Formatted Diff Diff
Patch (23.24 KB, patch) 2010-02-24 19:21 PST, Maciej Stachowiak	oliver: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Maciej Stachowiak

Comment 1 2010-02-21 20:29:31 PST

Created attachment 49181 [details] Patch

Darin Adler

Comment 2 2010-02-21 20:34:53 PST

Comment on attachment 49181 [details] Patch > void forgetDOMObject(DOMObject* wrapper, void* objectHandle) > { > + > JSC::JSGlobalData* globalData = Heap::heap(wrapper)->globalData(); No need for this added blank line. > - JSNode* getCachedDOMNodeWrapper(JSC::ExecState*, Document*, Node*); > + JSNode* getCachedDOMNodeWrapper(JSC::ExecState*, Node*); This is defined in JSNodeCustom.h instead of this header. Why? > + inline DOMObjectWrapperMap& DOMObjectWrapperMapFor(JSC::ExecState* exec) > + { > + return currentWorld(exec)->m_wrappers; > + } In the past we have lowercased even acronyms like DOM here at the start of a function name. Maybe there's some way to dodge the issue. r=me

WebKit Review Bot

Comment 3 2010-02-21 20:46:04 PST

Attachment 49181 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/297608

WebKit Review Bot

Comment 4 2010-02-21 20:49:07 PST

Attachment 49181 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/298397

Maciej Stachowiak

Comment 5 2010-02-22 01:28:47 PST

Committed r55074: <http://trac.webkit.org/changeset/55074>

Maciej Stachowiak

Comment 6 2010-02-22 02:33:58 PST

Reverted my change; it caused some breakage.