| Summary: | Cache JavaScript wrappers inline in DOM nodes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Maciej Stachowiak <mjs> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | gustavo, webkit.review.bot, xan.lopez | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Maciej Stachowiak
2010-02-21 20:12:48 PST
Created attachment 49181 [details]
Patch
Comment on attachment 49181 [details] Patch > void forgetDOMObject(DOMObject* wrapper, void* objectHandle) > { > + > JSC::JSGlobalData* globalData = Heap::heap(wrapper)->globalData(); No need for this added blank line. > - JSNode* getCachedDOMNodeWrapper(JSC::ExecState*, Document*, Node*); > + JSNode* getCachedDOMNodeWrapper(JSC::ExecState*, Node*); This is defined in JSNodeCustom.h instead of this header. Why? > + inline DOMObjectWrapperMap& DOMObjectWrapperMapFor(JSC::ExecState* exec) > + { > + return currentWorld(exec)->m_wrappers; > + } In the past we have lowercased even acronyms like DOM here at the start of a function name. Maybe there's some way to dodge the issue. r=me Attachment 49181 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/297608 Attachment 49181 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/298397 Committed r55074: <http://trac.webkit.org/changeset/55074> Reverted my change; it caused some breakage. Created attachment 49461 [details]
Patch
Comment on attachment 49461 [details]
Patch
r=me
Attachment 49461 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/309288 Attachment 49461 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/308324 Committed r55215: <http://trac.webkit.org/changeset/55215> |