Bug 35208
| Summary: | webkit-patch upload fails to upload large patches but does not report an error | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Maciej Stachowiak <mjs> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | abarth, dbates, enne, eric, simon.fraser |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Maciej Stachowiak
If a patch is over the 2M patch limit on bugs.webkit.org, webkit-patch upload will fail to upload it but will not report an error. Instead it appears to succeed.
https://bugs.webkit.org/show_bug.cgi?id=35206 has an example of such a patch.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adrienne Walker
*** Bug 58857 has been marked as a duplicate of this bug. ***
Eric Seidel (no email)
Sad times. We should look at the bugzilla error code I guess. I think we have similar trouble with misspelled CCs.
Eric Seidel (no email)
This is very similar to bug 31760.
I suspect that the two places we need to check (and yell loudly) are:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/steps/createbug.py#L52
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/steps/postdiff.py#L48
Possibly even returning or at least checking the result of browser.submit() here:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py#L483
Eric Seidel (no email)
Duping this against bug 72863 since there has been more activity there.
*** This bug has been marked as a duplicate of bug 72863 ***