Bug 35196

Summary: Move simplejson into webkitpy/thirdparty directory
Product: WebKit Reporter: Chris Jerdonek <cjerdonek>
Component: Tools / TestsAssignee: Chris Jerdonek <cjerdonek>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, eric, hamaji
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch abarth: review+, cjerdonek: commit-queue-

Chris Jerdonek
Reported 2010-02-20 11:56:58 PST
See summary.
Attachments
Proposed patch (48.24 KB, patch)
2010-02-20 12:07 PST, Chris Jerdonek 		abarth: review+
cjerdonek: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-02-20 12:07:25 PST
Created attachment 49132 [details] Proposed patch cq- since svn-create-patch does not support svn directory moves.
Chris Jerdonek
Comment 2 2010-02-20 12:08:43 PST
I will fix the typo: simpleson -> simplejson in the ChangeLog.
Adam Barth
Comment 3 2010-02-20 12:19:26 PST
Comment on attachment 49132 [details] Proposed patch This change is fine, but I don't think you added the files back...
Chris Jerdonek
Comment 4 2010-02-20 12:36:33 PST
(In reply to comment #3) > (From update of attachment 49132 [details]) > This change is fine, but I don't think you added the files back... Thanks again, Adam! I think the patch looks like that because svn-create-patch doesn't support moving directories. The svn-create-patch code has the following comment-- # Missing features: # # Handle copied and moved directories. I used svn move, and svn status shows the directory being added with history (and the files got moved on my local machine): svn status D WebKitTools/simplejson D WebKitTools/simplejson/LICENSE.txt ... A + WebKitTools/Scripts/webkitpy/thirdparty/simplejson ...
Chris Jerdonek
Comment 5 2010-02-20 12:45:51 PST
Manually committed using "svn commit" (to preserve history): http://trac.webkit.org/changeset/55057
Note You need to log in before you can comment on or make changes to this bug.