| Summary: | Move simplejson into webkitpy/thirdparty directory | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Jerdonek <cjerdonek> | ||||
| Component: | Tools / Tests | Assignee: | Chris Jerdonek <cjerdonek> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, cjerdonek, eric, hamaji | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Chris Jerdonek
2010-02-20 11:56:58 PST
Created attachment 49132 [details]
Proposed patch
cq- since svn-create-patch does not support svn directory moves.
I will fix the typo: simpleson -> simplejson in the ChangeLog. Comment on attachment 49132 [details]
Proposed patch
This change is fine, but I don't think you added the files back...
(In reply to comment #3) > (From update of attachment 49132 [details]) > This change is fine, but I don't think you added the files back... Thanks again, Adam! I think the patch looks like that because svn-create-patch doesn't support moving directories. The svn-create-patch code has the following comment-- # Missing features: # # Handle copied and moved directories. I used svn move, and svn status shows the directory being added with history (and the files got moved on my local machine): svn status D WebKitTools/simplejson D WebKitTools/simplejson/LICENSE.txt ... A + WebKitTools/Scripts/webkitpy/thirdparty/simplejson ... Manually committed using "svn commit" (to preserve history): http://trac.webkit.org/changeset/55057 |