Bug 35172

Summary: [Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup
Product: WebKit Reporter: James Hawkins <jhawkins>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
[Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup none

Description James Hawkins 2010-02-19 13:30:53 PST 
This fixes a crash when the AutoFill suggestions popup is shown and the user deletes enough characters so that the popup hides itself.  Patch will follow.
Comment 1 James Hawkins 2010-02-19 13:32:11 PST 
Created attachment 49102 [details]
[Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup
Comment 2 Eric Seidel (no email) 2010-02-19 14:17:12 PST 
Comment on attachment 49102 [details]
[Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup

What other popups (non-autocomplete) are we using?  Some sort of grammar/spelling?
Comment 3 James Hawkins 2010-02-19 14:18:46 PST 
The AutoFill popup is the other popup.  It behaves a bit differently than the Autocomplete popup.
Comment 4 WebKit Commit Bot 2010-02-19 14:51:00 PST 
Comment on attachment 49102 [details]
[Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup

Clearing flags on attachment: 49102

Committed r55032: <http://trac.webkit.org/changeset/55032>
Comment 5 WebKit Commit Bot 2010-02-19 14:51:04 PST 
All reviewed patches have been landed.  Closing bug.