Bug 35172

Summary: [Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup
Product: WebKit Reporter: James Hawkins <jhawkins>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
[Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup none

James Hawkins
Reported 2010-02-19 13:30:53 PST
This fixes a crash when the AutoFill suggestions popup is shown and the user deletes enough characters so that the popup hides itself. Patch will follow.
Attachments
[Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup (2.04 KB, patch)
2010-02-19 13:32 PST, James Hawkins 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Hawkins
Comment 1 2010-02-19 13:32:11 PST
Created attachment 49102 [details] [Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup
Eric Seidel (no email)
Comment 2 2010-02-19 14:17:12 PST
Comment on attachment 49102 [details] [Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup What other popups (non-autocomplete) are we using? Some sort of grammar/spelling?
James Hawkins
Comment 3 2010-02-19 14:18:46 PST
The AutoFill popup is the other popup. It behaves a bit differently than the Autocomplete popup.
WebKit Commit Bot
Comment 4 2010-02-19 14:51:00 PST
Comment on attachment 49102 [details] [Chromium] Use the m_suggestionsPopupClient pointer to refer to the popup client, as the Autocomplete popup might not be the current popup Clearing flags on attachment: 49102 Committed r55032: <http://trac.webkit.org/changeset/55032>
WebKit Commit Bot
Comment 5 2010-02-19 14:51:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.