Summary: | [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function | ||
---|---|---|---|
Product: | WebKit | Reporter: | James Hawkins <jhawkins> |
Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | commit-queue, dglazkov, eric, webkit.review.bot |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | All | ||
Attachments: |
Description
James Hawkins
2010-02-19 13:24:33 PST
Created attachment 49100 [details]
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function
Attachment 49100 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/288835 Created attachment 49103 [details]
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2]
It helps if you actually change the function declaration.
Comment on attachment 49103 [details]
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2]
OK.
Comment on attachment 49103 [details] [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2] Clearing flags on attachment: 49103 Committed r55031: <http://trac.webkit.org/changeset/55031> All reviewed patches have been landed. Closing bug. |