Bug 35171

Summary: [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function
Product: WebKit Reporter: James Hawkins <jhawkins>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function
none
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2] none

Description James Hawkins 2010-02-19 13:24:33 PST 
Now that there are two Suggestion popup clients, AutoFill and Autocomplete, this method should be renamed to properly reflect the purpose of the function.  Patch will follow.
Comment 1 James Hawkins 2010-02-19 13:26:36 PST 
Created attachment 49100 [details]
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function
Comment 2 WebKit Review Bot 2010-02-19 13:29:56 PST 
Attachment 49100 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/288835
Comment 3 James Hawkins 2010-02-19 13:35:29 PST 
Created attachment 49103 [details]
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2]

It helps if you actually change the function declaration.
Comment 4 Eric Seidel (no email) 2010-02-19 14:16:27 PST 
Comment on attachment 49103 [details]
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2]

OK.
Comment 5 WebKit Commit Bot 2010-02-19 14:35:01 PST 
Comment on attachment 49103 [details]
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2]

Clearing flags on attachment: 49103

Committed r55031: <http://trac.webkit.org/changeset/55031>
Comment 6 WebKit Commit Bot 2010-02-19 14:35:05 PST 
All reviewed patches have been landed.  Closing bug.