Bug 35171

Summary: [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function
Product: WebKit Reporter: James Hawkins <jhawkins>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function
none
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2] none

James Hawkins
Reported 2010-02-19 13:24:33 PST
Now that there are two Suggestion popup clients, AutoFill and Autocomplete, this method should be renamed to properly reflect the purpose of the function. Patch will follow.
Attachments
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function (2.86 KB, patch)
2010-02-19 13:26 PST, James Hawkins 		no flags
DetailsFormatted DiffDiff
[Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2] (3.02 KB, patch)
2010-02-19 13:35 PST, James Hawkins 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Hawkins
Comment 1 2010-02-19 13:26:36 PST
Created attachment 49100 [details] [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function
WebKit Review Bot
Comment 2 2010-02-19 13:29:56 PST
Attachment 49100 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/288835
James Hawkins
Comment 3 2010-02-19 13:35:29 PST
Created attachment 49103 [details] [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2] It helps if you actually change the function declaration.
Eric Seidel (no email)
Comment 4 2010-02-19 14:16:27 PST
Comment on attachment 49103 [details] [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2] OK.
WebKit Commit Bot
Comment 5 2010-02-19 14:35:01 PST
Comment on attachment 49103 [details] [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to onAutocompleteSuggestionAccepted to better match the purpose of the function [try2] Clearing flags on attachment: 49103 Committed r55031: <http://trac.webkit.org/changeset/55031>
WebKit Commit Bot
Comment 6 2010-02-19 14:35:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.