Bug 35166

Summary: [V8] Worker crashes due to r54972
Product: WebKit Reporter: Nate Chapin <japhet>
Component: WebCore Misc.Assignee: Nate Chapin <japhet>
Severity: Normal CC: dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
patch dglazkov: review+

Description Nate Chapin 2010-02-19 10:39:44 PST
I didn't properly test the worker-related changes in the final version of r54972, and I screwed up unwrapping global objects when we're in a WorkerContext.

Patch momentarily.
Comment 1 Nate Chapin 2010-02-19 10:51:28 PST
Created attachment 49092 [details]
Comment 2 Dimitri Glazkov (Google) 2010-02-19 10:53:14 PST
Comment on attachment 49092 [details]

Comment 3 Nate Chapin 2010-02-19 11:26:29 PST
Comment 4 Alexey Proskuryakov 2010-02-19 11:33:33 PST
Is this covered by existing regression tests?
Comment 5 Nate Chapin 2010-02-19 11:42:07 PST
(In reply to comment #4)
> Is this covered by existing regression tests?

Yes, but unfortunately, most (all?) of the tests that cover v8-related worker code are run under a full build of chromium, so problems didn't show up in any buildbots until chromium tried to merge passed r54972.

I thought I had run those tests locally prior to committing r54972, but apparently I hadn't.  Mea culpa.