Bug 35165

Summary: plugins/set-status.html fails on Windows bot
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Plug-insAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed fix mitz: review+

Alexey Proskuryakov
Reported 2010-02-19 10:27:56 PST
http://build.webkit.org/results/Windows%20Release%20%28Tests%29/r55012%20%289239%29/plugins/set-status-pretty-diff.html This is a pre-existing difference between Mac and Windows that's uncovered by this new test - Mac ignores null messages in NPN_SetMessage, while Windows treats them as empty ones. Mac Firefox sets status to "Done" when message is null - and since we don't say "Done" after finishing the load, the closest equivalent is an empty status.
Attachments
proposed fix (3.23 KB, patch)
2010-02-19 10:56 PST, Alexey Proskuryakov 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-02-19 10:56:44 PST
Created attachment 49095 [details] proposed fix
Alexey Proskuryakov
Comment 2 2010-02-19 11:00:04 PST
Committed <http://trac.webkit.org/changeset/55021>.
Note You need to log in before you can comment on or make changes to this bug.