Bug 35159

Summary: [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender and add results for passing new tests
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: New BugsAssignee: Andras Becsi <abecsi>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, kenneth, ossy, tonikitoo, vestbo
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch kenneth: review+, kenneth: commit-queue-

Description Andras Becsi 2010-02-19 08:43:34 PST 
EventSender did not implement textZoomIn() and textZoomOut() and so some new tests failed. Add expected files for these passing tests and skip the ones Which are in the Skiplist.
The differences to the Mac results are only due to SVG path dumping implementation differences and font size differences.
Comment 1 Andras Becsi 2010-02-19 08:53:18 PST 
Created attachment 49082 [details]
proposed patch
Comment 2 Antonio Gomes 2010-02-19 08:57:03 PST 
LGTM
Comment 3 Kenneth Rohde Christiansen 2010-02-19 08:58:39 PST 
Comment on attachment 49082 [details]
proposed patch

Looks good, but some comments


> +        [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results
> +        for passing new tests and unskip the passing ones from the Skiplist.

It is called Skipped, not Skiplist


> +    QWebFrame* frame = m_page->mainFrame();
> +    if (frame)
> +        frame->setTextSizeMultiplier(frame->textSizeMultiplier() * ZOOM_STEP);
> +}

Why not do

if (QWebFrame* frame = m_page->mainFrame())
    frame->setTextSizeMultiplier(frame->textSizeMultiplier() * ZOOM_STEP);

?
Comment 4 Andras Becsi 2010-02-19 09:15:24 PST 
Comment on attachment 49082 [details]
proposed patch

Updated patch committed in r55019. Closing bug.