Bug 35159 – [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender and add results for passing new tests

• Component: New Bugs
• Status: RESOLVED FIXED

[Andras Becsi]

EventSender did not implement textZoomIn() and textZoomOut() and so some new tests failed. Add expected files for these passing tests and skip the ones Which are in the Skiplist.
The differences to the Mac results are only due to SVG path dumping implementation differences and font size differences.

[Andras Becsi]

Created attachment 49082 [details]
proposed patch

[Antonio Gomes]

LGTM

[Kenneth Rohde Christiansen]

Comment on attachment 49082 [details]
proposed patch

Looks good, but some comments


> +        [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results
> +        for passing new tests and unskip the passing ones from the Skiplist.

It is called Skipped, not Skiplist


> +    QWebFrame* frame = m_page->mainFrame();
> +    if (frame)
> +        frame->setTextSizeMultiplier(frame->textSizeMultiplier() * ZOOM_STEP);
> +}

Why not do

if (QWebFrame* frame = m_page->mainFrame())
    frame->setTextSizeMultiplier(frame->textSizeMultiplier() * ZOOM_STEP);

?

[Andras Becsi]

Comment on attachment 49082 [details]
proposed patch

Updated patch committed in r55019. Closing bug.