Bug 35143

Summary:	check-webkit-style ignores JavaScriptCore/qt/api directory
Product:	WebKit	Reporter:	Jędrzej Nowacki <jedrzej.nowacki>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED DUPLICATE
Severity:	Normal	CC:	levin
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	All
OS:	All

Description Jędrzej Nowacki 2010-02-19 03:46:36 PST

check-webkit-style ignores *.cpp and *.h files inside the JavaScriptCore/qt/ subdirectory which I believe is wrong. 

Message posted by WebKit Review Bot:
Ignoring "JavaScriptCore/qt/api/qscriptstring.cpp": this file is exempt from
the style guide.

An use case can be found in bug 34843.

Comment 1 David Levin 2010-11-02 13:47:22 PDT

Is this a bug?

In WebKitTools/Scripts/webkitpy/style/checker.py, _SKIPPED_FILES_WITH_WARNING it sounds like this is because these are part of the qt api and it doesn't follow WebKit style.

If just a few rules should be omitted, this can be done in the section: _PATH_RULES_SPECIFIER

Comment 2 David Levin 2010-11-02 13:53:53 PDT

I'll resolve this of a dup of a later bug since it has a patch attached.

*** This bug has been marked as a duplicate of bug 48322 ***