Bug 35138

Summary: Improve interpreter getter performance
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Description Flags
Patch barraclough: review+

Description Oliver Hunt 2010-02-18 21:04:39 PST
Improve interpreter getter performance
Comment 1 Oliver Hunt 2010-02-18 21:11:18 PST
Created attachment 49055 [details]
Comment 2 WebKit Review Bot 2010-02-18 21:15:20 PST
Attachment 49055 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/interpreter/Interpreter.cpp:2166:  Missing spaces around &&  [whitespace/operators] [3]
JavaScriptCore/interpreter/Interpreter.cpp:2285:  Missing spaces around &&  [whitespace/operators] [3]
JavaScriptCore/interpreter/Interpreter.cpp:2348:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 3 in 9 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2010-02-18 22:20:46 PST
Comment on attachment 49055 [details]

pls to be removing bonus parens:

    if ((!slot.isCacheable())) {

Comment 4 Oliver Hunt 2010-02-18 22:23:34 PST
Committed r55002: <http://trac.webkit.org/changeset/55002>