Summary: | Improve interpreter getter performance | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Oliver Hunt
2010-02-18 21:04:39 PST
Created attachment 49055 [details]
Patch
Attachment 49055 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/interpreter/Interpreter.cpp:2166: Missing spaces around && [whitespace/operators] [3]
JavaScriptCore/interpreter/Interpreter.cpp:2285: Missing spaces around && [whitespace/operators] [3]
JavaScriptCore/interpreter/Interpreter.cpp:2348: Missing spaces around && [whitespace/operators] [3]
Total errors found: 3 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 49055 [details]
Patch
pls to be removing bonus parens:
if ((!slot.isCacheable())) {
r+
Committed r55002: <http://trac.webkit.org/changeset/55002> |