Bug 35138

Summary: Improve interpreter getter performance
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch barraclough: review+

Oliver Hunt
Reported 2010-02-18 21:04:39 PST
Improve interpreter getter performance
Attachments
Patch (26.09 KB, patch)
2010-02-18 21:11 PST, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2010-02-18 21:11:18 PST
Created attachment 49055 [details] Patch
WebKit Review Bot
Comment 2 2010-02-18 21:15:20 PST
Attachment 49055 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/interpreter/Interpreter.cpp:2166: Missing spaces around && [whitespace/operators] [3] JavaScriptCore/interpreter/Interpreter.cpp:2285: Missing spaces around && [whitespace/operators] [3] JavaScriptCore/interpreter/Interpreter.cpp:2348: Missing spaces around && [whitespace/operators] [3] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 3 2010-02-18 22:20:46 PST
Comment on attachment 49055 [details] Patch pls to be removing bonus parens: if ((!slot.isCacheable())) { r+
Oliver Hunt
Comment 4 2010-02-18 22:23:34 PST
Committed r55002: <http://trac.webkit.org/changeset/55002>
Note You need to log in before you can comment on or make changes to this bug.