Bug 35138 - Improve interpreter getter performance
Summary: Improve interpreter getter performance
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-18 21:04 PST by Oliver Hunt
Modified: 2010-02-18 22:23 PST (History)
1 user (show)

See Also:

Attachments
Patch (26.09 KB, patch)
2010-02-18 21:11 PST, Oliver Hunt 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2010-02-18 21:04:39 PST 
Improve interpreter getter performance
Comment 1 Oliver Hunt 2010-02-18 21:11:18 PST 
Created attachment 49055 [details]
Patch
Comment 2 WebKit Review Bot 2010-02-18 21:15:20 PST 
Attachment 49055 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/interpreter/Interpreter.cpp:2166:  Missing spaces around &&  [whitespace/operators] [3]
JavaScriptCore/interpreter/Interpreter.cpp:2285:  Missing spaces around &&  [whitespace/operators] [3]
JavaScriptCore/interpreter/Interpreter.cpp:2348:  Missing spaces around &&  [whitespace/operators] [3]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2010-02-18 22:20:46 PST 
Comment on attachment 49055 [details]
Patch

pls to be removing bonus parens:

    if ((!slot.isCacheable())) {

r+
Comment 4 Oliver Hunt 2010-02-18 22:23:34 PST 
Committed r55002: <http://trac.webkit.org/changeset/55002>