Bug 35133

Summary:	check-webkit-style should check for // namespace WebCore at end of namespace blocks
Product:	WebKit	Reporter:	Eric Seidel (no email) <eric>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED INVALID
Severity:	Normal	CC:	ap, cjerdonek, darin, hamaji, levin, zimmermann
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	PC
OS:	OS X 10.5
Bug Depends on:	33214
Bug Blocks:

Description Eric Seidel (no email) 2010-02-18 15:25:53 PST

check-webkit-style should check for // namespace WebCore at end of namespace blocks

As well as // #define FOO at end of #if FOO blocks.

Per numerous examples in the guidelines:
https://webkit.org/coding/coding-style.html

As well as discussion here:
https://lists.webkit.org/pipermail/webkit-dev/2009-September/009807.html

Comment 1 Nikolas Zimmermann 2010-02-18 15:28:08 PST

I think the rule needs to be removed. check-webkit-style should check that this is not present.
Please see the webkit-dev archive:
http://article.gmane.org/gmane.os.opendarwin.webkit.devel/10563/match=visual+noise

Has there been any outcome? CC'ing the people from the old discussion

Comment 2 Eric Seidel (no email) 2010-02-18 15:31:04 PST

Either way, we need to make our guidelines and our tools agree.  Right now there is only confusion.

Comment 3 Nikolas Zimmermann 2010-02-18 15:35:16 PST

(In reply to comment #2)
> Either way, we need to make our guidelines and our tools agree.  Right now
> there is only confusion.

Agreed. Consistency is all.

Comment 4 David Levin 2010-02-18 17:27:48 PST

(In reply to comment #3)
> (In reply to comment #2)
> > Either way, we need to make our guidelines and our tools agree.  Right now
> > there is only confusion.
> 
> Agreed. Consistency is all.

Actually, the check for the comment at the end of ifdef blocks was added and then removed per discussion: http://old.nabble.com/-endif----Foo_h-td27021241.html

(I really need to get to updating the style guide as a result of my email but this part of it, regarding ifdef comments, will not go in per the emails above.)

Comment 5 David Levin 2010-11-02 13:36:35 PDT

This is not a suggested style but some may find it helpful in some circumstances.

Comment 6 Eric Seidel (no email) 2010-11-02 14:43:26 PDT

Sigh.  I'm sad that this is left ambiguous.

Comment 7 David Levin 2010-11-02 14:47:33 PDT

(In reply to comment #6)
> Sigh.  I'm sad that this is left ambiguous.

fwiw, it sounds like in general it is recommended not to put it in and that seems to be the general consensus. (I'm not sure that the consensus was strong enough to put into a check-webkit-style rule.)