Summary: | [Qt] ENABLE_3D_RENDERING should be optional | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||
Component: | WebKit Qt | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | laszlo.gombos | ||||
Priority: | P2 | Keywords: | Qt | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Noam Rosenthal
2010-02-18 07:31:11 PST
Created attachment 49020 [details]
ENABLE_3D_RENDERING moved to be a normal feature
This seems to rectify the problem for ENABLE_3D_RENDERING (moved to be a normal feature, rather than a forced define).
However, I'm not sure how to do that for WTF_ENABLE_ACCELERATED_COMPOSITING, which doesn't appear as a "feature". Help would be appreciated.
The patch looks good to me, if we only try to restrict it to ENABLE_3D_RENDERING. Noam, can you change the bug title and ChangeLog accordingly ? I think we should open another bug for ACCELERATED_COMPOSITING as it will likely involve changes to other ports as well, not just for QtWebKit. In general USE(xx) flags are not meant to be turn on/off optionally at build time within a given WebKit port. Comment on attachment 49020 [details]
ENABLE_3D_RENDERING moved to be a normal feature
LGTM, r+. I will update the title in the ChangeLogs as well during a manual commit.
Comment on attachment 49020 [details] ENABLE_3D_RENDERING moved to be a normal feature Committed as http://trac.webkit.org/changeset/55056. |