Bug 35059

Summary: New port: EFL; adding files to WebKit/efl
Product: WebKit Reporter: Leandro Pereira <leandro>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Enhancement CC: barbieri, bunhere, gns, gyuyoung.kim, hyuki.a.kim, hyuki.kim, joone.hur, miroslaw.s, rakuco, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
Add EFL port files in WebKit/efl
kenneth: review-
Image files needed by the EFL port none

Description Leandro Pereira 2010-02-17 14:45:26 PST
Created attachment 48940 [details]
Add EFL port files in WebKit/efl

This patch is part of a series of patches to add an updated version of the EFL port to the WebKit tree.

This particular patch adds files to WebKit/efl directory, including necessary image files (stored in webkit-efl-port-webkit_efl.tar, also attached). Changes to the port-independent parts and build system changes, will come later.

It should apply cleanly on SVN rev 54651.
Comment 1 Leandro Pereira 2010-02-17 14:46:28 PST
Created attachment 48941 [details]
Image files needed by the EFL port
Comment 2 Gustavo Sverzut Barbieri 2010-02-17 16:03:15 PST
I'm interested in the review process of this item, so adding it to CC.

ProFUSION wrote WebKit-EFL on behalf of Samsung Electronics, which now wants to contribute back and we'll maintain this port upstream as things should be ;-)

The port was based on previous attempt by INdT, however most of WebKit/efl was rewritten to fit better EFL architecture. The files that include INdT's work have their copyright listed accordingly.
Comment 3 Leandro Pereira 2010-02-18 03:48:00 PST
Changing platform to Other / Linux.
Comment 4 Leandro Pereira 2010-02-18 03:59:25 PST
Comment on attachment 48940 [details]
Add EFL port files in WebKit/efl

Mark patch for review.Mark patch for review.
Comment 5 Kenneth Rohde Christiansen 2010-02-18 04:35:59 PST
Comment on attachment 48940 [details]
Add EFL port files in WebKit/efl

It is a very big patch, would it be possible to split it up? Also, r- as there is no ChangeLog entry. 

Please use the prepare-ChangeLog to create ChangeLog entries. Also, read the page on webkit.org on how to contribute.

Also, we try to not commit out-commented code, please remove that.
Comment 6 Gustavo Noronha (kov) 2010-02-18 05:48:19 PST
(In reply to comment #5)
> (From update of attachment 48940 [details])
> It is a very big patch, would it be possible to split it up? Also, r- as there
> is no ChangeLog entry. 

I suggest a good first step would be to get enough build system in to build EFL's JavaScriptCore, what do you think?
Comment 7 Leandro Pereira 2010-03-31 14:28:34 PDT
All files included in the attached patch either already landed (through smaller patches with their respective bug reports) or are awaiting review, so I am closing this bug.