Bug 35054 – [gtk] windowless plugins don't get button mask on mouse motion events

• Component: Plug-ins
• Status: RESOLVED WONTFIX

[Brian Tarricone]

I imagine this is also true of the Qt backend, but I'm working on gtk, so...

Currently the windowless plugin code doesn't set Button1MotionMask (or Button2MotionMask or Button3MotionMask) when sending XMotionEvents to the plugin.  Will attach patch after I get a bug # for the changelog...

[Brian Tarricone]

Created attachment 48932 [details]
pass button mask to windowless plugins in XMotionEvent

... and here's our fix.

[Eric Seidel (no email)]

Comment on attachment 48932 [details]
pass button mask to windowless plugins in XMotionEvent

How do we test this?  It should be possible using the test plugin included with DumpRenderTree.

[Brian Tarricone]

(In reply to comment #2)
> (From update of attachment 48932 [details])
> How do we test this?  It should be possible using the test plugin included with
> DumpRenderTree.

For me, I have an in-house NPAPI plugin I'm using (which is how I came across the bug).  In the NPAPI event handler, you can check that XMotionEvent::state contains Button1MotionMask when button one is held down (and similar for buttons 2 and 3).

Not sure if the DumpRenderTree test plugin (I didn't even know it had one!) can easily be modified to do th same thing.

[Eric Seidel (no email)]

http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/TestNetscapePlugIn.subproj

[Holger Freyther]

I agree with Eric... using the EventSender and the test plugin we should be able to test this automatically.

[Eric Seidel (no email)]

Comment on attachment 48932 [details]
pass button mask to windowless plugins in XMotionEvent

OK.  How do we test this?

TestPlugin.cpp + window.eventSender should be able to do it, no?

[Brian Tarricone]

Created attachment 56202 [details]
attempt at test (doesn't work)

Here's my first attempt at a test using eventSender and the test npapi plugin, but I can't get it to work.  I verified that the DumpRenderTree window gets events, but eventSender doesn't seem to be working at all.  Any ideas?  Is it known to work on linux/gtk?

[Brian Tarricone]

Created attachment 56203 [details]
the test html/js

Whoops, forgot the actual test file too.

[Martin Robinson]

EventSender should be working on WebKitGTK+. Are you still looking into this?

[Martin Robinson]

The original patch was for WebKit1, which is going to be removed soon. I'm going to close this bug for now, but please reopen if it's still an issue with WebKit2.