Bug 35053

Summary: run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, levin, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 34984    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2010-02-17 13:28:10 PST
run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree
Attachments
Patch (4.62 KB, patch)
2010-02-17 13:30 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-02-17 13:30:28 PST
Created attachment 48931 [details] Patch
Ojan Vafai
Comment 2 2010-02-17 13:44:00 PST
Not a reviewer, but r=me if I were. :)
Adam Barth
Comment 3 2010-02-18 00:01:08 PST
Comment on attachment 48931 [details] Patch Lame that script_path isn't on the base class of WebKitPort. Why is it on SCM? More fodder for our webkitpy TODO wave.
WebKit Commit Bot
Comment 4 2010-02-18 00:54:53 PST
Comment on attachment 48931 [details] Patch Clearing flags on attachment: 48931 Committed r54945: <http://trac.webkit.org/changeset/54945>
WebKit Commit Bot
Comment 5 2010-02-18 00:54:57 PST
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 6 2010-02-18 02:56:30 PST
SCM is what knows where the base of the checkout is. Also, the idea of a "port" is very recent. :) scm.py was the 3rd python file bugzilla-tool ever had!
Note You need to log in before you can comment on or make changes to this bug.