Bug 35053 - run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree
Summary: run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprende...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 34984
  Show dependency treegraph
 
Reported: 2010-02-17 13:28 PST by Eric Seidel (no email)
Modified: 2010-02-18 02:56 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.62 KB, patch)
2010-02-17 13:30 PST, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-02-17 13:28:10 PST
run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree
Comment 1 Eric Seidel (no email) 2010-02-17 13:30:28 PST
Created attachment 48931 [details]
Patch
Comment 2 Ojan Vafai 2010-02-17 13:44:00 PST
Not a reviewer, but r=me if I were. :)
Comment 3 Adam Barth 2010-02-18 00:01:08 PST
Comment on attachment 48931 [details]
Patch

Lame that script_path isn't on the base class of WebKitPort.  Why is it on SCM?  More fodder for our webkitpy TODO wave.
Comment 4 WebKit Commit Bot 2010-02-18 00:54:53 PST
Comment on attachment 48931 [details]
Patch

Clearing flags on attachment: 48931

Committed r54945: <http://trac.webkit.org/changeset/54945>
Comment 5 WebKit Commit Bot 2010-02-18 00:54:57 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Eric Seidel (no email) 2010-02-18 02:56:30 PST
SCM is what knows where the base of the checkout is.

Also, the idea of a "port" is very recent. :) scm.py was the 3rd python file bugzilla-tool ever had!