Bug 35002

Summary: [Android] V8 bindings include bindings/npruntime.h, which is Chromium-specific
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, commit-queue, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Attachments:
Description Flags
Patch none

Steve Block
Reported 2010-02-16 15:09:58 PST
V8 bindings include bindings/npruntime.h This file is in Chromium's tree outside of WebKit, so causes build errors on Android. The include sites should be updated to use WebCore/bridge/npruntime.h for Android. In the long term, the Chromium-specific changes to bindings/npruntime.h should probably be upstreamed.
Attachments
Patch (4.38 KB, patch)
2010-02-16 15:17 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-02-16 15:17:06 PST
Created attachment 48839 [details] Patch
Ariya Hidayat
Comment 2 2010-02-16 15:43:03 PST
Comment on attachment 48839 [details] Patch LGTM.
WebKit Commit Bot
Comment 3 2010-02-17 02:05:04 PST
Comment on attachment 48839 [details] Patch Clearing flags on attachment: 48839 Committed r54880: <http://trac.webkit.org/changeset/54880>
WebKit Commit Bot
Comment 4 2010-02-17 02:05:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.