Bug 35002 - [Android] V8 bindings include bindings/npruntime.h, which is Chromium-specific
Summary: [Android] V8 bindings include bindings/npruntime.h, which is Chromium-specific
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Android Android
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-16 15:09 PST by Steve Block
Modified: 2010-02-17 02:05 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.38 KB, patch)
2010-02-16 15:17 PST, Steve Block
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Block 2010-02-16 15:09:58 PST
V8 bindings include bindings/npruntime.h This file is in Chromium's tree outside of WebKit, so causes build errors on Android.

The include sites should be updated to use WebCore/bridge/npruntime.h for Android.

In the long term, the Chromium-specific changes to bindings/npruntime.h should probably be upstreamed.
Comment 1 Steve Block 2010-02-16 15:17:06 PST
Created attachment 48839 [details]
Patch
Comment 2 Ariya Hidayat 2010-02-16 15:43:03 PST
Comment on attachment 48839 [details]
Patch

LGTM.
Comment 3 WebKit Commit Bot 2010-02-17 02:05:04 PST
Comment on attachment 48839 [details]
Patch

Clearing flags on attachment: 48839

Committed r54880: <http://trac.webkit.org/changeset/54880>
Comment 4 WebKit Commit Bot 2010-02-17 02:05:08 PST
All reviewed patches have been landed.  Closing bug.