| Summary: | websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromium-webkit-tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
| Component: | Tools / Tests | Assignee: | Fumitoshi Ukai <ukai> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dpranke, ojan, ukai, yutak | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 34984 | ||||||
| Attachments: |
|
||||||
|
Description
Eric Seidel (no email)
2010-02-16 15:06:48 PST
We probably need to merge http://codereview.chromium.org/565027 upstream (the fix for https://bugs.webkit.org/show_bug.cgi?id=34289). Created attachment 48852 [details]
Patch
Comment on attachment 48852 [details]
Patch
That seems like the wrong path.
(In reply to comment #3) > (From update of attachment 48852 [details]) > That seems like the wrong path. What do you mean? A path for -x is the relative path to document root, and this path is the same used in WebKitTools/Scripts/run-webkit-websocketserver. (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 48852 [details] [details]) > > That seems like the wrong path. > > What do you mean? > A path for -x is the relative path to document root, and this path is the same > used in WebKitTools/Scripts/run-webkit-websocketserver. Note that current chromium would fail this test. need http://codereview.chromium.org/601077 to pass the test. Comment on attachment 48852 [details]
Patch
LGTM.
Attachment 48852 [details] was posted by a committer and has review+, assigning to Fumitoshi Ukai for commit.
Committed r54920: <http://trac.webkit.org/changeset/54920> |