Bug 34997

Summary: Add call to FrameLoaderClient::allowPlugins everywhere arePluginsEnabled is called
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, gustavo, pkasting, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch fishd: review+, fishd: commit-queue+

Adam Barth
Reported 2010-02-16 14:12:28 PST
Add call to FrameLoaderClient::allowPlugins everywhere arePluginsEnabled is called
Attachments
Patch (4.12 KB, patch)
2010-02-16 14:14 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (4.57 KB, patch)
2010-02-20 23:19 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (4.58 KB, patch)
2010-02-20 23:45 PST, Adam Barth 		fishd: review+
fishd: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-02-16 14:14:05 PST
Created attachment 48831 [details] Patch
Eric Seidel (no email)
Comment 2 2010-02-16 14:17:05 PST
Attachment 48831 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/271553
WebKit Review Bot
Comment 3 2010-02-16 14:24:24 PST
Attachment 48831 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/271555
WebKit Review Bot
Comment 4 2010-02-16 14:42:28 PST
Attachment 48831 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/271577
Adam Barth
Comment 5 2010-02-16 18:05:54 PST
Comment on attachment 48831 [details] Patch Oops. Will try again.
Adam Barth
Comment 6 2010-02-20 23:19:44 PST
Created attachment 49142 [details] Patch
Adam Barth
Comment 7 2010-02-20 23:20:40 PST
This time I actually tried it. :)
WebKit Review Bot
Comment 8 2010-02-20 23:25:34 PST
Attachment 49142 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/296159
Adam Barth
Comment 9 2010-02-20 23:45:05 PST
Created attachment 49143 [details] Patch
Eric Seidel (no email)
Comment 10 2010-02-24 14:56:29 PST
Comment on attachment 49143 [details] Patch Why not just add a new method on Loader which does this check? Seems slightly silly to have to copy/paste this large line.
Adam Barth
Comment 11 2010-02-24 15:49:02 PST
> Why not just add a new method on Loader which does this check? Sounds like a good idea. Will do in a followup patch.
Peter Kasting
Comment 12 2010-02-24 16:17:25 PST
Landed in r55206.
Note You need to log in before you can comment on or make changes to this bug.