| Summary: | Add call to FrameLoaderClient::allowPlugins everywhere arePluginsEnabled is called | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dglazkov, eric, gustavo, pkasting, webkit.review.bot, xan.lopez | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Adam Barth
2010-02-16 14:12:28 PST
Created attachment 48831 [details]
Patch
Attachment 48831 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/271553 Attachment 48831 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/271555 Attachment 48831 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/271577 Comment on attachment 48831 [details]
Patch
Oops. Will try again.
Created attachment 49142 [details]
Patch
This time I actually tried it. :) Attachment 49142 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/296159 Created attachment 49143 [details]
Patch
Comment on attachment 49143 [details]
Patch
Why not just add a new method on Loader which does this check?
Seems slightly silly to have to copy/paste this large line.
> Why not just add a new method on Loader which does this check?
Sounds like a good idea. Will do in a followup patch.
Landed in r55206. |